Conversation
| packet.setOldSkinName(""); | ||
| packet.setNewSkinName(skin.textureUrl()); | ||
| packet.setSkin(getSkin(session, skin.textureUrl(), skin, cape, geometry)); | ||
| packet.setSkin(getSkin(session, skin.textureUrl(), skin, cape, geometry, false, true)); |
There was a problem hiding this comment.
Nitpick, maybeee use isPersona, isCapeOnClassic instead of false, true here...
There was a problem hiding this comment.
I dont really see a reason for this considering java players are considered classic skins anyway
onebeastchris
left a comment
onebeastchris
left a comment
There was a problem hiding this comment.
Looks like "persona" is always false here, so i'm unsure what that's good for... esp if Geyser doesn't support those skins anyways :p
Does just setting the capeOnClassic property work? Would rather just change that tbh
| boolean isPersona = false; | ||
| boolean isCapeOnClassic = true; |
There was a problem hiding this comment.
Why are these local variables? Doesn't seem like they're used for anything else
| .geometryData(geometry.geometryData().isBlank() ? GEOMETRY : geometry.geometryData()) | ||
| .premium(true) | ||
| .capeId(cape.capeId()) | ||
| .fullSkinId(skinId) |
|
i think it does, will clean up this pr when i get the time |
|
Honestly, given that https://bugs-legacy.mojang.com/browse/MCPE-53595 existed for years.. i'm unsure if we should implement this. For players, seeing the same cape everywhere might be more confusing compared to not seeing any capes on elytras... |
onebeastchris
added
PR: On hold
3 participants
Closes #4374.
However, due to a bug in the Bedrock Edition client, the elytras will swap with another player (see video below).
ScreenRecording_11-04-2025_19-58-25_1.mov