Open
Conversation
oryxel1
changed the title
oryxel1
changed the title
onebeastchris
requested changes
Jan 11, 2026
Member
onebeastchris
left a comment
onebeastchris
left a comment
There was a problem hiding this comment.
Thanks for the PR! I wonder if we should move the lerp logic up to the Entity class and use a shouldLerp() method to avoid duplication.. although i'm fine with the structure as-is
Is seems odd that we would lerp movements when a vehicle is controlled by the client. Is that intended?
Looking at Java client handling would imply that we should not be lerping in those cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forget boat, should close #2490 (well this issue doesn't really occur anymore, at least not as bad but this will fixed it completely)
also