Add Java Combat Sounds #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey! Thanks for the PR. After some discussion internally, we've decided to wait with these changes until Geyser is providing a resource pack by default - to ensure that there are no cases where not having the pack can impact gameplay. |
Contributor
Author
|
Cool! At least this will possibly be considered sometime in the future again. I might go back and change the sound id to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Combat Sounds from Java Edition to Geyser. Note that the strong and weak combat sounds are not included, this is because they are already in the games resources. Requires GeyserMC/mappings#94 to be accepted.