Skip to content

Fix compatibility issue regarding non-character version specification #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pormr wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix compatibility issue regarding non-character version specification #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36c3f09
Fix compatiblity issue for comparing versions
pormr Feb 25, 2025
beb9826
Fix Seurat v5 compatibility by setting compatibility mode to v3
pormr Mar 17, 2026
76c2f7d
Fix regression in previous commit that caused version check failure.
pormr Mar 17, 2026
94b775f
style: update formatting to match existing style
pormr Mar 18, 2026
69ea74d
fix: update DESCRIPTION
pormr Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ Imports:
proxy,
methods,
rlang,
withr,
RoxygenNote: 7.2.3
Suggests:
SingleCellExperiment,
Expand Down
9 changes: 5 additions & 4 deletions R/supercell_2_Seurat.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,12 @@ supercell_2_Seurat <- function(SC.GE, SC, fields = c(),
if(length(SC.fields) > 0){
meta <- cbind(meta, SC.fields)
}
m.seurat <- Seurat::CreateSeuratObject(counts = SC.GE, meta.data = meta)

if(packageVersion("Seurat") >= 5){
m.seurat[["RNA"]] <- as(object = m.seurat[["RNA"]], Class = "Assay")
if(packageVersion("Seurat") >= "5.0.0"){
withr::local_options(list(Seurat.object.assay.version = "v3"))
}

m.seurat <- Seurat::CreateSeuratObject(counts = SC.GE, meta.data = meta)

if(!do.preproc) return(m.seurat)

Expand Down Expand Up @@ -173,7 +174,7 @@ supercell_2_Seurat <- function(SC.GE, SC, fields = c(),
warning("Super-cell graph was not found in SC object, no super-cell graph was added to Seurat object")
}

if(packageVersion("Seurat") >= 5 & output.assay.version == "v5"){
if(packageVersion("Seurat") >= "5.0.0" & output.assay.version == "v5"){
m.seurat[["RNA"]] <- as(object = m.seurat[["RNA"]], Class = "Assay5")
}
return(m.seurat)
Expand Down