fix: collab-server in kubernetes not working due to hardcoded graphql_engine hostname #795
+7
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
To fix #794
Description of the Change
Allow
graphql_enginehostname customization incollab-serverdeployment, to allow Ghostwriter to be fully operational when deployed in Kubernetes.To do so, you can set
GRAPHQL_HOSTenv var incollab-serverdeployment to matchgraphql_engineservice name.Alternate Designs
We may have graphql_engine change to something RFC1123 compliant everywhere, but it's way more easier to allow to set
graphql_enginehostname incollab-server.Possible Drawbacks
There should be none, as the default behavior (not setting the env var) is the same as before.
Verification Process
I've tested the modification in a kubernetes cluster.
Release Notes
Allow
graphql_enginehostname customization incollab-serverdeployment