Reorganize code #10
Closed
Reorganize code #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LKajan
commented
Sep 27, 2024
LKajan
commented
- Use src structure
- Move gui components to own subpackage
We don't need to compile any source files anymore so there is no need to build the plugin. Use a symlink to test the plugin instead.
Use default gitignore template from GitHub to reduce the risk to commit undesired files.
nmaarnio
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Ok for me, although I would like to ask why have a folder called arho_feature_template with only qgis_plugin_tools under it? I also personally prefer being able to control when the updated code goes into QGIS, but I'm happy to try the symlink way.
Is it problematic that we have two folders called arho_feature_template? According to VSCode there seems to be some broken qgis_plugin_tools imports in plugin.py
|
The plugin ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.