107 suodatus kaavamääräyksille ja kaavamääräysryhmille #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmaarnio
force-pushed
the
107-suodatus-kaavamääräyksille-ja-kaavamääräysryhmille
branch
3 times, most recently
from
2b77f17 to
daa4663
Compare
LKajan
approved these changes
Jan 16, 2025
| from qgis.PyQt.QtWidgets import QSizePolicy, QTreeWidget, QTreeWidgetItem, QVBoxLayout, QWidget | ||
|
|
||
|
|
||
| class TreeWithSearchWidget(QWidget): |
There was a problem hiding this comment.
Tää on tosiaan aika simppeli widget eikä niin väliä, mutta oliko joku syy miksi tätä ei tehty Designerilla ui-tiedostoksi?
There was a problem hiding this comment.
Eipä juuri. Taisin vaan ajatella, että kivempi laittaa yhteen tiedostoon kun mahtui hyvin / oli sen verran vähän alustuskoodia
| self.regulations_tree_layout.insertWidget(1, self.regulations_selection_widget) | ||
| self.regulations_selection_widget.tree.itemDoubleClicked.connect(self.add_selected_regulation) | ||
| self.regulations_selection_widget.tree.itemClicked.connect(self.update_selected_regulation) | ||
| [self._initalize_regulation_from_config(config) for config in RegulationLibrary.get_regulations()] |
There was a problem hiding this comment.
Mielestäni tässä ei hyötyä käyttä list comprehensionia.
There was a problem hiding this comment.
Niin, aika pitkälti tyylikysymys ja oon itse 50-50 comprehensionin ja loopin välillä tälläsissä tapauksissa. Voin hyvin vaihtaa
nmaarnio
force-pushed
the
107-suodatus-kaavamääräyksille-ja-kaavamääräysryhmille
branch
from
daa4663 to
c7f5fa3
Compare
…ature form and plan attribute form
nmaarnio
force-pushed
the
107-suodatus-kaavamääräyksille-ja-kaavamääräysryhmille
branch
from
c7f5fa3 to
07a9db7
Compare
nmaarnio
deleted the
107-suodatus-kaavamääräyksille-ja-kaavamääräysryhmille
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.