Kaavasuositukset kaavakohteille #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKajan
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Yksi ehkä kriittinen kommentti olisi, että tallentuuko muokattaessa kantaan koskemattomista kaavamääräysryhmistä aina uusi assosiaatio?
Yksi keino noiden kaavamääräysryhmien assiosiaatioiden hallintaan voisi olla, että kaavamääräysryhmämodeliin lisäisi esim. association_status-attribuutin ja se voisi olla existing, new, deleted. Widgetissä ei tietenkään näytettäisi modeleita, joilla tuo on deleted. Sitten kohteen kaavamääräysryhmät voisi loopata ja poistaa assosiaatiot, joilla status deleted ja luoda ne joilla new. Ja jättää huomioimatta existing. Muuten pitää jotenkin etsiä kannasta ne jotka jo olemassa ja jotka poistuneet (kuten nyt oot tehnytkin get_dangling_associations).
LKajan
approved these changes
Jan 21, 2025
nmaarnio
force-pushed
the
113-kaavasuositukset
branch
2 times, most recently
from
c4dddd9 to
b3c12f3
Compare
- add plan proposition model - add widget for plan proposition - handle saving and loading plan propositions for plan regulation groups - add possibility to define plan propositions for custom plan regulation groups - add PlanThemeLayer code layer model - remove spacer and horizontal line layout items from plan regulation widget
- use LANGUAGE constant, defined in misc_utils for now - add AdditionalInformationTypeLayer and define get_additional_information_name for it - add get_attribute_value_by_another_attribute_value for AbstractLayer
nmaarnio
force-pushed
the
113-kaavasuositukset
branch
from
b3c12f3 to
484c8f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on PR #112