Kaavamääräysryhmän lomakkeen otsikon dynaaminen nimeäminen #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmaarnio
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
This works, but I think it could be better to change the title within the form to be more future-proof (if the form is opened from another place in code). There is already a check whether the given regulation group model has an id, and we could perform the renaming there (so plan_regulation_group_form.py line 107->)
nmaarnio
approved these changes
Feb 24, 2025
nmaarnio
force-pushed
the
156-kaavamaarayksen-otsikointi-dynaamisesti
branch
2 times, most recently
from
c9f8c0b to
cc92272
Compare
Moved renaming of plan regulation group from's title to already existing id check.
nmaarnio
force-pushed
the
156-kaavamaarayksen-otsikointi-dynaamisesti
branch
from
cc92272 to
5ad1ecd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynaamisesti vaihtaa kaavamääräysryhmän lomakkeen otsikon riippuen luodaanko uutta vai editoidaanko olemassaolevaa.