Korjaa olemassa olevien kaavamääräysryhmien lisääminen #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LKajan
approved these changes
Feb 25, 2025
Comment on lines
117
to
130
| if ( | ||
| not ( | ||
| reg_group_widget.regulation_group.id_ and short_name == reg_group_widget.regulation_group.short_name | ||
| ) | ||
| and short_name in self.existing_group_short_names | ||
| ): |
There was a problem hiding this comment.
Mun oli vaikea ymmärtää mitä tässä tarkistetaan. Saisiko ehtoa selkeytettyä jotenkin näin?
Suggested change
| if ( | |
| not ( | |
| reg_group_widget.regulation_group.id_ and short_name == reg_group_widget.regulation_group.short_name | |
| ) | |
| and short_name in self.existing_group_short_names | |
| ): | |
| def is_existing_model_with_unmodified_short_name(model, short_name): | |
| return model.id_ and short_name == model.short_name | |
| if ( | |
| not is_existing_model_with_unmodified_short_name(reg_group_widget.regulation_group, short_name) | |
| and short_name in self.existing_group_short_names | |
| ): |
nmaarnio
force-pushed
the
203-olemassa-olevaa-kaavamääräysryhmää-ei-voi-lisätä-kaavakohteelle
branch
from
85f000a to
9c8d8d4
Compare
LKajan
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.