Lomakkeen tuottaminen templaatista

[nmaarnio]

No description provided.

[LKajan]

Nice!
Let's go with this one and modify later on. I added few minor comments.

We should probably at some point change more towards a mvc pattern and create/fill a model from the template and create the form from the model.

[LKajan]

My understanding is that its a common practice to define the types in the class section as following:

Suggested change

	class PlanRegulationGroupWidget(QWidget, FormClass): # type: ignore
	"""A widget representation of a plan regulation group."""
	delete_signal = pyqtSignal(QWidget)
	def __init__(self, feature: Feature):
	super().__init__()
	self.setupUi(self)
	# TYPES
	self.frame: QFrame
	self.heading: QLineEdit
	self.del_btn: QPushButton
	class PlanRegulationGroupWidget(QWidget, FormClass): # type: ignore
	"""A widget representation of a plan regulation group."""
	# TYPES
	frame: QFrame
	heading: QLineEdit
	del_btn: QPushButton
	delete_signal = pyqtSignal(QWidget)
	def __init__(self, feature: Feature):
	super().__init__()
	self.setupUi(self)

[nmaarnio]

I used to do it like this too, until at some point VSCode stopped recognizing this sort of typing for me... If it is an editor bug, I will look into it more

[LKajan]

I think layouts are accessible by the layout name defined in QtDesigner so no need the function call.

[nmaarnio]

I think it depends whether the layout is added as a separate item or only set to a widget unless I am mistaken. The top-level layout in this widget was only "set" and not as a separate entry in the widget tree.

[LKajan]

The "main" layouts of widgets are not shown in the widget tree but the name of the used layout is configurable in the widget's property editor under the layout section.