Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

81 lue kaavamääräyslajit QGISin tasolta #82

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

nmaarnio
Copy link
Collaborator

@nmaarnio nmaarnio commented Nov 29, 2024

kaavamaaraykset.yaml config file was redesigned to be minimal and completed (all needed information about plan regulations should be now included) as part of this PR.

@nmaarnio nmaarnio linked an issue Nov 29, 2024 that may be closed by this pull request
@nmaarnio nmaarnio added the enhancement New feature or request label Nov 29, 2024
@nmaarnio nmaarnio marked this pull request as ready for review December 2, 2024 11:01
@nmaarnio
Copy link
Collaborator Author

nmaarnio commented Dec 2, 2024

Note: Still missing type of verbal plan regulation

@nmaarnio nmaarnio requested a review from LKajan December 2, 2024 11:02
- modified PlanRegulationConfig and PlanRegulationSet classes
- modified kaavammaraykset.yaml to only include missing information about regulations
- initialize PlanRegulationSet only when it is needed for the first time
@nmaarnio nmaarnio force-pushed the 81-lue-kaavamääräyslajit-qgisin-tasolta branch from fee8d28 to 654a41b Compare December 3, 2024 12:48
Copy link
Contributor

@LKajan LKajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@nmaarnio nmaarnio merged commit 700f1ff into main Dec 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lue kaavamääräyslajit QGISin tasolta
2 participants