-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tietojen tallentaminen kaavakohteen lomakkeesta (sis. kaavamääräysryhmien ja kaavamääräyksien tallennuksen) #95
Merged
nmaarnio
merged 6 commits into
main
from
feature_saving_for_regulations_and_regulation_groups
Dec 17, 2024
Merged
Tietojen tallentaminen kaavakohteen lomakkeesta (sis. kaavamääräysryhmien ja kaavamääräyksien tallennuksen) #95
nmaarnio
merged 6 commits into
main
from
feature_saving_for_regulations_and_regulation_groups
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, feature saving still TBD
- plan features are saved - plan regulation groups are saved - plan regulations are saved Notes: - saving additional information for regulations is not implemented yet - saving value ranges for regulations is not implemented yet - saving files for regulations is not implemented yet - reading saved features into forms and updating them is not implemented yet - saving regulation groups in new plan regulation group form is not implemented yet - using existing regulation groups for plan features is not implemented yet - plan feature target layer selection is hard coded for now - underground type is hard coded for now - plan organisation needs to be set to Toimija code layer to make a new plan - PlanRegulationSet could be refactored into PlanTypeLayer class - save_data methods could be refactored to reduce code repetition
0c56e85
to
382138b
Compare
- add regulation group type selection and short name - fix versioned text input widget - fix numeric input widget - move data saving funcs to plan manager - add placeholder mapping logic to target plan feature layer selection
382138b
to
3b5aae1
Compare
LKajan
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muuten näyttää hyvältä, mutta oliko tarkoitus, että tämä tallentaisi kaavamääräysryhmät kaavakohteille. Tällä hetkellä ei taida sitä vielä tehdä.
LKajan
requested changes
Dec 17, 2024
LKajan
approved these changes
Dec 17, 2024
5a5c306
to
449df8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.