Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tietojen tallentaminen kaavakohteen lomakkeesta (sis. kaavamääräysryhmien ja kaavamääräyksien tallennuksen) #95

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

nmaarnio
Copy link
Collaborator

No description provided.

@nmaarnio nmaarnio added the enhancement New feature or request label Dec 12, 2024
@nmaarnio nmaarnio changed the title (WIP) feature saving for regulations and regulation groups Tietojen tallentaminen kaavakohteen lomakkeesta (sis. kaavamääräysryhmien ja kaavamääräyksien tallennuksen) Dec 16, 2024
- plan features are saved
- plan regulation groups are saved
- plan regulations are saved

Notes:
- saving additional information for regulations is not implemented yet
- saving value ranges for regulations is not implemented yet
- saving files for regulations is not implemented yet
- reading saved features into forms and updating them is not implemented yet
- saving regulation groups in new plan regulation group form is not implemented yet
- using existing regulation groups for plan features is not implemented yet

- plan feature target layer selection is hard coded for now
- underground type is hard coded for now

- plan organisation needs to be set to Toimija code layer to make a new plan

- PlanRegulationSet could be refactored into PlanTypeLayer class
- save_data methods could be refactored to reduce code repetition
@nmaarnio nmaarnio force-pushed the feature_saving_for_regulations_and_regulation_groups branch from 0c56e85 to 382138b Compare December 16, 2024 11:47
@nmaarnio nmaarnio marked this pull request as ready for review December 16, 2024 11:47
@nmaarnio nmaarnio requested a review from LKajan December 16, 2024 11:47
- add regulation group type selection and short name
- fix versioned text input widget
- fix numeric input widget
- move data saving funcs to plan manager
- add placeholder mapping logic to target plan feature layer selection
@nmaarnio nmaarnio force-pushed the feature_saving_for_regulations_and_regulation_groups branch from 382138b to 3b5aae1 Compare December 16, 2024 14:22
Copy link
Contributor

@LKajan LKajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muuten näyttää hyvältä, mutta oliko tarkoitus, että tämä tallentaisi kaavamääräysryhmät kaavakohteille. Tällä hetkellä ei taida sitä vielä tehdä.

@nmaarnio nmaarnio requested a review from LKajan December 17, 2024 08:57
@nmaarnio nmaarnio force-pushed the feature_saving_for_regulations_and_regulation_groups branch from 5a5c306 to 449df8b Compare December 17, 2024 11:35
@nmaarnio nmaarnio merged commit d5329d1 into main Dec 17, 2024
7 checks passed
@nmaarnio nmaarnio deleted the feature_saving_for_regulations_and_regulation_groups branch December 17, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants