Docker fix

[wardjm]

Sorry about taking this on so suddenly. I know you said someone else might be working it. This is all the initial changes required to build and run via docker.

[wardjm]

I should also comment to make sure to test your normal build process. I think everything was done in parallel with *_docker files (since the paths change), but may have accidentally messed something up unwittingly.

[GitHubProUser67]

Tada! We do! 65535 is (for now) used for the auto-IP negatiation, but I think... I will change it to be under 65532 anyway (the other port is trojan sensitive).

[wardjm]

Thanks! So it should be exposed for MitM? That comment reflected that only one of them can bind on that address/port pair, but all of the vcproj files listed it. So it just cannot be true that they all listen on the same port on the same computer.

[GitHubProUser67]

You are welcome!

Yes it should, but it is not an obligation.

This can be used by any server.

There is a lock system in place to make sure the port is not used twice at the same time.

And the listener will not remain on all the time, it only open the port and listen when needed.

[Jump-Suit]

As someone who uses MultiServer components dockerized, the edits to the existing dockerfiles do not satisfy docker image build conditions, as the other project references in the .csprojs are missing entries in the dockerfiles themselves.

Just to note, Right-Clicking in VS the project, and Add Docker Support to the project itself, will automatically adjust the dockerfiles to how they should be for compiling even if the files exist.

[wardjm]

As someone who uses MultiServer components dockerized, the edits to the existing dockerfiles do not satisfy docker image build conditions, as the other project references in the .csprojs are missing entries in the dockerfiles themselves.

Just to note, Right-Clicking in VS the project, and Add Docker Support to the project itself, will automatically adjust the dockerfiles to how they should be for compiling even if the files exist.

Thanks! I'd like to get this settled. Is it possible to say specifically what the problem is? Everything builds and runs, so I assume we are just missing a component or two. The entire source tree is copied over to the build images, so they don't have to be listed individually to be built there. Certainly this pull is way closer to correct than what currently exists.

[GitHubProUser67]

I think it now works without doing other project references because since, there is the deps fixer that modified the program startup net config file to take into account costura fody.

Is it possible to test it in a docker linux system?

[Jump-Suit]

I've built my Docker images directly on my backend via Portainer, if the dependencies aren't included in the dockerfiles, they won't be found and will be considered missing upon attempt to compile.

[GitHubProUser67]

Can you indicate how to do it?

I think this is worth the inclusion for wardjm but if you know how to do it and where to do it, it can save time I guess.

[wardjm]

I guess we are sort of at an impasse here. Jump claims all of the Docker stuff is broken but if you right-click add docker support it fixes them. But he hasn't committed those fixes for some reason. I claim the current proposed docker compose solution builds everything (listed) correctly. This is verifiable by running the commands in the README. Jump is refusing to state what doesn't build for him. I suspect everything listed builds (but we are missing some components?), but I was trying to go off of what was in the docker files that existed since I hadn't run the programs before. I'm new to the project and don't want to step on anyone's toes, but I need some more specific information if I can fix the problem. This is a docker compose solution as was already in the source code (but it was outdated referencing folders that don't exist anymore). I'm not sure about Portainer as I haven't used it.

[GitHubProUser67]

I tested your Pull Request, it does work very well on my wsl docker.

I do agree we need more context if one specific thing we don't know requires fixing.

I will reach out to Jump to see if he can give us the full context.

[GitHubProUser67]

So I had some response regarding how to update the dockerfiles. Can you try following these steps to see if it works for you?

[wardjm]

I believe this is updated to work with the Visual Studio changes now. I tested on my end and it seems to work. I only have one game that can connect though.

[GitHubProUser67]

Ok, this sounds good, in the next big update there is some of your PR integrated. What game did you tested on it?

[wardjm]

I tested it using Riding Club Championships. It can't create an account (and hence can't log in), but I see all the messages going through. I assume the account creation stuff is a separate issue.