Fix dropdown overlay not staying fixed #3164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d980d7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Summary of the deployments: Version 1
Version 2
Test content |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
taranvohra
reviewed
Apr 16, 2025
Comment on lines
+20
to
+21
| /** Whether to use fixed positioning (for fixed navbars) */ | ||
| useFixedPosition?: boolean; |
There was a problem hiding this comment.
I am not sure to understand why we need a special prop for this. The default behaviour of the dropdown is it's fixed and anchored to it's parent no matter what the situation is. Exposing a prop like this leaks implementation details that is not very clear for the caller of this API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to be a quick fix to solve a bug. We should probably move to a more properly supported Dropdown element like react-aria or Radix. But this works for now.
Before
CleanShot.2025-04-15.at.16.56.54.mp4
After
CleanShot.2025-04-15.at.16.57.29.mp4