Skip to content

Revamp mobile navigation #3282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

nolannbiron
Copy link
Member

No description provided.

@nolannbiron nolannbiron self-assigned this Jun 7, 2025
Copy link

changeset-bot bot commented Jun 7, 2025

🦋 Changeset detected

Latest commit: ea170d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

argos-ci bot commented Jun 7, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ⚠️ Changes detected (Review) 16 changed Jun 9, 2025, 4:16 PM
customers-v2 (Inspect) ⚠️ Changes detected (Review) 87 changed Jun 9, 2025, 4:18 PM
default (Inspect) ⚠️ Changes detected (Review) 27 changed Jun 9, 2025, 4:19 PM
v2-cloudflare (Inspect) ⚠️ Changes detected (Review) 20 changed, 8 removed, 1 failure Jun 9, 2025, 4:22 PM
v2-vercel (Inspect) ⚠️ Changes detected (Review) 20 changed, 8 removed, 1 failure Jun 9, 2025, 4:23 PM

Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can negatively impact perfs as it means the TOC will be rendered twice; we have spaces with thousands of pages, which can result in a big HTML chunk just for mobile

@nolannbiron
Copy link
Member Author

@SamyPesse Probably not the sexiest approach, but this way we can preserve the initial HTML (desktop TOC) and switch to the Sheet TOC for mobile, so no duplicate

I’m not a big fan of relying on useIsMobile, but given that we’re passing a context props (not serializable) to a lot of components, it’s tricky to implement a clean client-side solution without breaking things

I still think it's a good improvement and it won't change anything on desktop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants