Prioritise unused change addresses for split #85
Merged
+40
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickfarrow
force-pushed
the
splitunused
branch
2 times, most recently
from
c22b931 to
34ccefb
Compare
nickfarrow
force-pushed
the
splitunused
branch
from
e4541fa to
dbea379
Compare
LLFourn
requested changes
Feb 10, 2022
nickfarrow
force-pushed
the
splitunused
branch
from
dbea379 to
d95e631
Compare
LLFourn
reviewed
Feb 11, 2022
src/cmd/wallet.rs
Outdated
| @@ -579,7 +636,7 @@ pub fn run_split_cmd(wallet: &GunWallet, opt: SplitOpt) -> anyhow::Result<CmdOut | |||
| // add one recipient so we at least get one split utxo of the correct size. | |||
| .add_recipient( | |||
| bdk_wallet | |||
| .get_change_address(AddressIndex::New)? | |||
| .get_change_address(AddressIndex::LastUnused)? | |||
There was a problem hiding this comment.
Hmm so this bit doesn't fix the underlying problem with split_change. Perhaps for now the best thing to do is to make the number of outputs mandatory so we don't have to use split_change.
After this is merged we should make a PR to BDK adding FirstUnused and batch address fetch to BDK and maybe introduce split_change with that.
LLFourn
added a commit
that referenced
this pull request
Feb 16, 2022
* prioritise unused change addresses for split * Fix clippy warnings Co-authored-by: LLFourn <lloyd.fourn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alleviates #66
Based on #81
Unused change addresses are used first (searched from index 0 up to and including last_unused), and then fill rest of outputs with new addresses. Only creates one new change address in best case.