Add tap tempo window setting with localization support #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
This pull request references my pull request on goxlr-utility, and adds support for configuring the "Tap Tempo Window" setting in the device settings modal, allowing users to adjust the maximum time between taps for tap-tempo detection. The change introduces a new number setting in the UI and provides translations for the new setting in all supported languages.
Device Settings UI Enhancement:
NumberSettinginput for "Tap Tempo Window" inDeviceSettingsButton.vue, allowing users to set the tap-tempo detection window in milliseconds. The input is shown only if the device supports the setting, and values are clamped between 1000 and 2000 ms. [1] [2]Localization Updates:
de_DE.js), English (en_GB.js), Spanish (es_ES.js), French (fr_FR.js), Italian (it_IT.js), Dutch (nl_NL.js), Polish (pl_PL.js), and Russian (ru_RU.js). [1] [2] [3] [4] [5] [6] [7] [8]