java-storage dependency cleanup #1046
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1046 +/- ##
============================================
+ Coverage 82.75% 82.77% +0.02%
Complexity 1803 1803
============================================
Files 104 104
Lines 8164 8164
Branches 1002 1002
============================================
+ Hits 6756 6758 +2
+ Misses 1006 1004 -2
Partials 402 402
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BenWhitehead
reviewed
Sep 1, 2023
pom.xml
Outdated
| <google.auth.version>1.14.0</google.auth.version> | ||
| <google.auto-value.version>1.10.1</google.auto-value.version> | ||
| <google.cloud-core.verion>2.9.0</google.cloud-core.verion> | ||
| <google.cloud-storage.bom.version>2.25.0</google.cloud-storage.bom.version> | ||
| <!-- Library bom for Java-Storage --> | ||
| <google.cloud-storage.library.bom.version>26.21.0</google.cloud-storage.library.bom.version> |
There was a problem hiding this comment.
Libraries-bom will apply to all cloud clients, gax, guava, grpc, http client, etc.
I'd probably remove storage from the property name.
BenWhitehead
approved these changes
Sep 6, 2023
|
Is this still going to happen? @arunkumarchacko this is expected to reduce complexity of dependency management in Dataproc. |
|
ping on this @singhravidutt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.