-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Evaluate your AI Agent using Vertex AI Gen AI Evaluation service Notebook #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
View / edit / reply to this conversation on ReviewNB sanjanalreddy commented on 2025-07-14T00:40:17Z PS: Clear all the output cells, to keep the notebook clean olex-snk commented on 2025-07-14T09:01:57Z Cleaned |
View / edit / reply to this conversation on ReviewNB sanjanalreddy commented on 2025-07-14T00:40:19Z Format NOTE to be bold and don't make it a header olex-snk commented on 2025-07-14T09:07:37Z Reformatted |
View / edit / reply to this conversation on ReviewNB sanjanalreddy commented on 2025-07-14T00:40:20Z Can you simplify the explanation to be more understandable? Here's an option, "Normally, To fix this, you can use a library called
Also please add links as hyperlinks instead of adding them directly. olex-snk commented on 2025-07-14T12:40:51Z Fixed explanation, added hyperlinks |
View / edit / reply to this conversation on ReviewNB sanjanalreddy commented on 2025-07-14T00:40:20Z Update markdown to be more descriptive. "We'll define plotting helper functions to visualize the results from evaluation as bar, radar...etc." |
View / edit / reply to this conversation on ReviewNB sanjanalreddy commented on 2025-07-14T00:40:21Z Update formate of NOTE to be bold and not a header. olex-snk commented on 2025-07-14T09:05:58Z Reformatted |
View / edit / reply to this conversation on ReviewNB sanjanalreddy commented on 2025-07-14T00:40:21Z Remove this cell if you aren't going to use it. |
View / edit / reply to this conversation on ReviewNB sanjanalreddy commented on 2025-07-14T00:40:22Z Remove the note regarding BYOD here since you'll cover that in the notebook later. olex-snk commented on 2025-07-14T09:09:24Z Removed |
View / edit / reply to this conversation on ReviewNB sanjanalreddy commented on 2025-07-14T00:40:22Z Line #1. EXPERIMENT_NAME = "evaluate-adk-agent-v1" # @param {type:"string"} Remove the comments regarding parameter type since we are not using colab, this isn't required. #param {type:"string"} |
View / edit / reply to this conversation on ReviewNB sanjanalreddy commented on 2025-07-14T00:40:23Z Line #4. !gsutil mb -l {LOCATION} {BUCKET_URI} This throws an exception if the bucket already exists. Add a conditional statement to check if the bucket exists and only create the bucket if the bucket doesn't exist. olex-snk commented on 2025-07-14T13:28:41Z Added conditional statement to check if the bucket exists |
Cleaned View entire conversation on ReviewNB |
Reformatted View entire conversation on ReviewNB |
Reformatted View entire conversation on ReviewNB |
Removed View entire conversation on ReviewNB |
Fixed explanation, added hyperlinks View entire conversation on ReviewNB |
Added conditional statement to check if the bucket exists View entire conversation on ReviewNB |
@@ -0,0 +1,1698 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,1698 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #2. BUCKET_NAME = "put_your_ai_agent_evaluation_adk_bucket"
This line will throw an error if a hard-coded bucket name is used since bucket names have to be unique for everyone. My recommendation is to use the PROJECT ID as the bucket name like this instead:
PROJECT = !gcloud config list --format 'value(core.project)' PROJECT = PROJECT[0] BUCKET_NAME = PROJECT BUCKET_URI = f"gs://{BUCKET_NAME}"
Reply via ReviewNB
@@ -0,0 +1,1713 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use the uuid
library instead of creating a this custom method for simplicity.
import uuid uuid = uuid.uuid4()
Reply via ReviewNB
@olex-snk Here's my suggestion regarding nest_asyncio. #634 |
ebdc431
to
f4bb6b5
Compare
This pull request introduces an example of the notebook with guides on how to evaluate an ADK (Agent Development Kit) agent using Vertex AI Gen AI Evaluation for agent evaluation.