-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Remove adk kernel & updated ADK version #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
takumiohym
commented
Oct 1, 2025
- Updated ADK version to 1.14.1 (Chose this version since >=1.15.0 updates other dependencies including protobuf.)
- Removed ADK kernel
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Summary of ChangesHello @takumiohym, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the development environment by updating the Agent Development Kit (ADK) to version 1.14.1 and eliminating the need for a separate ADK-specific Jupyter kernel. This change simplifies setup for users by consolidating dependencies within the base Python environment and updating relevant notebook configurations and Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the custom ADK kernel and updates the ADK version to 1.14.1, simplifying the notebook setup. The changes rely on a standard pip installation of google-adk
and adjust the PATH
environment variable accordingly. The updates are consistent with the description and improve the overall user experience. I have one suggestion to enhance portability.
"\n", | ||
"# Set `PATH` to include the directory containing ADK command\n", | ||
"PATH = %env PATH\n", | ||
"%env PATH=/home/jupyter/.local/bin:{PATH}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding the path with /home/jupyter
makes the notebook less portable across different environments. It's better to programmatically retrieve the user's home directory using os.path.expanduser('~')
to ensure the code runs correctly for any user.
"%env PATH=/home/jupyter/.local/bin:{PATH}" | |
"%env PATH={os.path.expanduser('~')}/.local/bin:{PATH}" |
@takumiohym Was this meant to be added to the keras3-dev branch? |
@sanjanalreddy Yes, because ADK lib is added to requirements.txt along with the keras 3 update in the keras3-dev branch. |