Allow for the service account email to be provided for a Pub/Sub BigQuery subscription #2677
+79
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uery subscription
|
THanks for this PR, can you add a quick example test in the module's README, or modify one of the existing ones? |
|
Added an example in the README as requested. |
|
Committed a fix for the liniting / test failures |
auto-merge was automatically disabled
November 13, 2024 07:44
Head branch was pushed to by a user without write access
|
Hopefully that should resolve the testing failures. |
|
This is still failing, please check our contributing guide on how to write tests. Closing this PR, will reopen with fixed code. Thanks for pushing this forward. |
auto-merge was automatically disabled
November 14, 2024 06:35
Pull request was closed
ludoo
added a commit
that referenced
this pull request
Nov 14, 2024
ludoo
added a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for the service account email to be provided for a Pub/Sub BigQuery subscription.
PR that will allow you to define and pass-through the
service_account_emailattribute to thebigquery_config.