Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GPU options to compute-vm module #2689

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

ooshrioo
Copy link
Contributor


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link

google-cla bot commented Nov 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ludoo ludoo changed the title add GPU options to comute-vm module add GPU options to compute-vm module Nov 14, 2024
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, glad you made it :) Dropped a couple comments, feel free to ping me if you need clarifications

modules/compute-vm/variables.tf Outdated Show resolved Hide resolved
modules/compute-vm/main.tf Show resolved Hide resolved
@ludoo
Copy link
Collaborator

ludoo commented Nov 17, 2024

Oshri, can you sign our CLA?

@juliocc juliocc force-pushed the ooshrioo/compute-vm-gpu branch from a8a6158 to c275f40 Compare November 18, 2024 15:14
@juliocc juliocc enabled auto-merge (squash) November 18, 2024 15:16
@juliocc juliocc merged commit ef597a3 into GoogleCloudPlatform:master Nov 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants