Skip to content

chore: fix CreateBlueprintDisplayMetadata function when there is no existing input #2660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024
Merged

chore: fix CreateBlueprintDisplayMetadata function when there is no existing input #2660

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f02ce3c
fix CreateBlueprintDisplayMetadata function when there is no existing…
tjy9206 Oct 18, 2024
9f9ba62
Merge branch 'master' into master
q2w Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cli/bpmetadata/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,12 @@ func CreateBlueprintDisplayMetadata(bpPath string, bpDisp, bpCore *BlueprintMeta
bpDisp.Spec.Info.Source = bpCore.Spec.Info.Source
buildUIInputFromVariables(bpCore.Spec.Interfaces.Variables, bpDisp.Spec.Ui.Input)

existingInput := proto.Clone(bpCore.Spec.Ui.Input).(*BlueprintUIInput)
existingInput := func() *BlueprintUIInput {
if bpCore.Spec.Ui != nil && bpCore.Spec.Ui.Input != nil {
return proto.Clone(bpCore.Spec.Ui.Input).(*BlueprintUIInput)
}
return &BlueprintUIInput{}
}()
// Merge existing data (if any) into the newly generated UI Input
mergeExistingAltDefaults(bpDisp.Spec.Ui.Input, existingInput)

Expand Down
Loading