Skip to content

Conversation

vicentefb
Copy link
Contributor

variableValue yaml tag inside DisplayVariableToggle field needs to be updated to be variableValues to be consistent.

@vicentefb vicentefb requested review from a team and q2w as code owners December 26, 2024 23:58
@vicentefb
Copy link
Contributor Author

@g-awmalik

Copy link
Collaborator

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vicentefb
Copy link
Contributor Author

Yes @apeabody done, thanks!

@vicentefb vicentefb requested a review from apeabody January 8, 2025 19:04
@apeabody
Copy link
Collaborator

apeabody commented Jan 8, 2025

Yes @apeabody done, thanks!

Thanks @vicentefb - I'll defer to @g-awmalik for final approval as this appears to be a potentially breaking change.

@vicentefb
Copy link
Contributor Author

I might need to hold this until an update is made to a query as well as the removal of an old field which is not reflected here.

@apeabody
Copy link
Collaborator

I might need to hold this until an update is made to a query as well as the removal of an old field which is not reflected here.

Hi @vicentefb - Please remove the do not merge label when it's ready for review.

Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Mar 25, 2025
@github-actions github-actions bot closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants