refactor: add ConnectionName class
#1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
commented
Nov 1, 2024
| @@ -51,6 +51,7 @@ def lint(session): | |||
| "--check-only", | |||
| "--diff", | |||
| "--profile=google", | |||
| "-w=88", | |||
There was a problem hiding this comment.
black formatter uses line-length of 88 while isort was using 85, setting isort to 88 as well.
Found this as the new import for _parse_instance_connection_name was 87 characters and causing isort and black to argue with one another.
hessjcg
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors all instance connection name related code into
its own file
connection_name.py.It introduces the
ConnectionNameclass which will make trackingif a DNS name was given to the Connector easier in the future.
This change also aligns the Python Connector more closely to its
Go counterpart's
conn_name.gofor easier maintainability.Related to #1169