Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back diff from PR #3406 and bump toolkit docker default terraform version 1.5.2 -> 1.5.7 #3597

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

mohitchaurasia91
Copy link
Contributor

@mohitchaurasia91 mohitchaurasia91 commented Jan 28, 2025

Adding back kubectl provider change from #3406 (incl in v1.45.0), reverted through #3573 (incl in hotfix v1.45.1)

Tested this change for toolkit docker default compatibility with #3406 kubectl provider change, work as expected for terraform version 1.5.7, so bumping default terraform version from 1.5.2 -> 1.5.7

This will sync the toolkit docker default setup with install dependencies doc

Used following command for local docker build for test purpose

docker build --build-arg CLUSTER_TOOLKIT_REF=v1.45.0 \
             --build-arg TERRAFORM_VERSION=1.5.7 \
             -t gcluster-terraform-1_5_7 .

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

…cker default terraform version 1.5.2 -> 1.5.7
@mohitchaurasia91 mohitchaurasia91 added release-module-improvements Added to release notes under the "Module Improvements" heading. release-version-updates Added to release notes under the "Version Updates" heading. labels Jan 28, 2025
@mohitchaurasia91 mohitchaurasia91 self-assigned this Jan 28, 2025
@mohitchaurasia91 mohitchaurasia91 marked this pull request as ready for review January 28, 2025 07:43
@mohitchaurasia91 mohitchaurasia91 changed the title Add back changes from PR #3406 and bump toolkit docker default terraform version 1.5.2 -> 1.5.7 Add back diff from PR #3406 and bump toolkit docker default terraform version 1.5.2 -> 1.5.7 Jan 28, 2025
Copy link
Contributor

@annuay-google annuay-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested one clarification

Copy link
Contributor

@annuay-google annuay-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Terraform version bump- verified
Not verifying individual loc for kubectl provider as PR is adding back a reverted PR

@mohitchaurasia91 mohitchaurasia91 added the do-not-merge Block merging of this PR label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Block merging of this PR release-module-improvements Added to release notes under the "Module Improvements" heading. release-version-updates Added to release notes under the "Version Updates" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants