Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Toolkit - new module for creating Artifact Registries #3639

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

scott-nag
Copy link
Collaborator

@scott-nag scott-nag commented Feb 5, 2025

Cluster Toolkit Updates

Introduction of a module to handle Artifact Registry operations: README

OFE Updates

  • Re-enabled the latest Terraform (1.4 was being used temporarily due to cluster deletion bug)
  • Included an option for Private Service Access to the VPC creation page
  • Added views for displaying Artifact Registry repositories that are created alongside clusters, as well as placeholder views that will soon be used to handle container operations
  • Updated OFE cluster creation page to include a section for creating Artifact Registries per the TF module
  • Fixed an issue with extraction of the Slurm controller location as it had change in the TFState file
  • Updated the cluster page to remove the deprecated enable_smt field and replace it with advanced_machine_features.threads_per_core
  • Python update 3.8 -> 3.12

I do have one question about pre-commit/Terraform. The variables file here contains validation which I have commented out as pre-commit wasn't happy. I was seeing errors like this: The condition for variable "repo_password" can only refer to the variable itself, using var.repo_password despite it working when I was testing it locally - is there a different/preferred way that I can re-add these rules again?

Any questions please feel free to give me a shout. Many thanks

@scott-nag scott-nag changed the title Develop Cluster Toolkit - new module for creating Artifact Registries Feb 5, 2025
@scott-nag scott-nag added the release-new-modules Added to release notes under the "New Modules" heading. label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-new-modules Added to release notes under the "New Modules" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant