Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyperdisk-ml support for gke-storage #3672

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

saltysoup
Copy link
Contributor

Hyperdisk-ml is the recommended storage for speeding up load times and inference of larger models eg. DeepSeek-R1, Llama3-405b, which often takes a long time ~20min+

Source: https://cloud.google.com/kubernetes-engine/docs/tutorials/serve-multihost-gpu#speed_up_model_load_times_with_hyperdisk_ml

This PR is to add hyperdisk-ml support by adding this disk type as a valid condition in variables.tf, and new templates for storage class and PVC

Comment on lines +6 to +11
%{~ for key, val in labels ~}
${key}: ${val}
provisioner: pd.csi.storage.gke.io
allowVolumeExpansion: true
parameters:
%{~ endfor ~}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this for really meant to be that long?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by long? FWIW i used the same template as hyperdisk-extreme (noticed its slightly different to hyperdisk-balanced template).

Hyperdisk-ml doesnt support customizable IOPS so i took that out. I also didnt include custom throughput as it automatically specifies this based on disk size

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected something like this:

Suggested change
%{~ for key, val in labels ~}
${key}: ${val}
provisioner: pd.csi.storage.gke.io
allowVolumeExpansion: true
parameters:
%{~ endfor ~}
%{~ for key, val in labels ~}
${key}: ${val}
%{~ endfor ~}
provisioner: pd.csi.storage.gke.io
allowVolumeExpansion: true
parameters:

I think you don't need to repeat provsioner and allowVolmeExpansion, and most imporatantly, you don't want them missing if no labels are provided. And to me it looks like hyperdisk-extreme has the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants