Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubectl #3680

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Fix kubectl #3680

wants to merge 8 commits into from

Conversation

annuay-google
Copy link
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

samskillman
samskillman requested changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@samskillman samskillman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple files need to be reverted. Also please add a description to the PR As to what this change does.

examples/gke-a3-ultragpu/gke-a3-ultragpu-deployment.yaml
@@ -16,16 +16,16 @@
terraform_backend_defaults:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be reverted.

tools/cloud-build/images/cluster-toolkit-dockerfile/Dockerfile
@@ -57,7 +57,7 @@ ENV PATH $PATH:/usr/local/go/bin:$GOPATH/bin

# Clone the Cluster Toolkit repository
ARG CLUSTER_TOOLKIT_REF=main
RUN git clone --branch ${CLUSTER_TOOLKIT_REF} https://github.com/GoogleCloudPlatform/cluster-toolkit.git /cluster-toolkit
RUN git clone --branch annuay/fix-kubectl https://github.com/annuay-google/cluster-toolkit.git /cluster-toolkit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

@annuay-google annuay-google marked this pull request as draft February 20, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samskillman samskillman samskillman requested changes

@chengcongdu chengcongdu Awaiting requested review from chengcongdu chengcongdu is a code owner

@douglasjacobsen douglasjacobsen Awaiting requested review from douglasjacobsen douglasjacobsen is a code owner

@yuryu yuryu Awaiting requested review from yuryu yuryu is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@annuay-google annuay-google

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annuay-google @samskillman @mohitchaurasia91