Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using google_compute_image data source #3776

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Mar 8, 2025

Due to hashicorp/terraform-provider-google#21766 stop using data "google_compute_image".

  • Following validations has been removed:
    • Check that boot disk size >= image size;
    • Check that image license is aligned with allow_automatic_updates.
  • Move duplicate source_image_logic.tf into community/modules/internal/slurm-gcp/image_logic;
  • Remove default instance_image values from user facing modules.

@mr0re1 mr0re1 requested review from samskillman and a team as code owners March 8, 2025 07:33
@mr0re1 mr0re1 added the release-chore To not include into release notes label Mar 8, 2025
Copy link
Collaborator

@rohitramu rohitramu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should wait on this PR until we get a response on hashicorp/terraform-provider-google#21766, for a few reasons:

  • The failure mode "disk size is less than image size" is difficult to identify and diagnose in a deployment
  • Removing the default image value almost certainly makes the user experience worse - a beginner Cluster Toolkit user may pick a non-Slurm image and be confused as to why nothing's working
  • Image deletion seems like a rare problem with an easy workaround (don't delete in-use images)

Copy link
Collaborator

@rohitramu rohitramu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline.

@rohitramu rohitramu assigned mr0re1 and unassigned rohitramu Mar 11, 2025
@mr0re1 mr0re1 enabled auto-merge March 11, 2025 05:05
@mr0re1 mr0re1 merged commit a088db8 into GoogleCloudPlatform:develop Mar 11, 2025
10 of 59 checks passed
@mr0re1 mr0re1 deleted the image_of_void branch March 11, 2025 05:24
rohitramu added a commit to rohitramu/hpc-toolkit that referenced this pull request Mar 11, 2025
…_of_void"

This reverts commit a088db8, reversing
changes made to 97cd448.
rohitramu added a commit that referenced this pull request Mar 11, 2025
Revert "Merge pull request #3776 from mr0re1/image_of_void"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants