-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using google_compute_image
data source
#3776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitramu
requested changes
Mar 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should wait on this PR until we get a response on hashicorp/terraform-provider-google#21766, for a few reasons:
- The failure mode "disk size is less than image size" is difficult to identify and diagnose in a deployment
- Removing the default image value almost certainly makes the user experience worse - a beginner Cluster Toolkit user may pick a non-Slurm image and be confused as to why nothing's working
- Image deletion seems like a rare problem with an easy workaround (don't delete in-use images)
rohitramu
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline.
- I still feel that the failure mode "disk size is less than image size" is difficult to identify and diagnose in a deployment. We should add this check back when
data "google_compute_image"
fails on destroy path if image doesn't exist hashicorp/terraform-provider-google#21766 is resolved - A default image will still be selected if one isn't provided - the specific image just isn't defined in the nodeset or login node settings. This shouldn't have as big an impact on user experience.
rohitramu
added a commit
that referenced
this pull request
Mar 11, 2025
Revert "Merge pull request #3776 from mr0re1/image_of_void"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to hashicorp/terraform-provider-google#21766 stop using
data "google_compute_image"
.allow_automatic_updates
.source_image_logic.tf
intocommunity/modules/internal/slurm-gcp/image_logic
;instance_image
values from user facing modules.