feat[Spanner]: Add samples for new features #2550
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
the
samples
amanda-tarafa
force-pushed
the
spanner-directed-reads
branch
from
a993120 to
53abbc0
Compare
|
@jskeet I've re-requested review as I fixed a copyright year and the previous approval was lost. |
amanda-tarafa
force-pushed
the
spanner-directed-reads
branch
2 times, most recently
from
3e39c6a to
79e70c2
Compare
|
We'll do dependency updates and all sample in this PR in separate commits, it's all easier to manage. |
amanda-tarafa
changed the title
|
@jskeet Here are the dependency updates for Spanner samples and the samples themselves, you had already reviewed one sample but not the other. |
| return rowsInserted; | ||
| }); | ||
|
|
||
| Console.WriteLine("Data inserted."); |
There was a problem hiding this comment.
I'm not sure how this is compiling - isn't this unreachable code? (We've got a return statement just above it.)
There was a problem hiding this comment.
Well it's compiling also in local. But you are right it is unreachable, I'll remove it (and I'll check from where I copied it.)
- Fix a sample that was not using the intendend transaction. Caught because of transaction inlining. - Use the new ambient transaction methods as the existing ones are now deprecated.
amanda-tarafa
force-pushed
the
spanner-directed-reads
branch
from
10ce033 to
94bef87
Compare
|
Failures are unrelated and being tracked in #1623 . Force merging. |
Tests won't pass until googleapis/google-cloud-dotnet#12164 is merged and release. I'm currently running them locally.