feat(parametermanager): created folder to add samples #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
samples
amanda-tarafa
requested changes
Feb 25, 2025
There was a problem hiding this comment.
Also, when you start writing the actual samples, make sure to
- Follow the contributing guide
- Several smaller PRs are better than a huge one. It's easier to review and bring to completion one small PR than a bigger one. Learnings from a small PR can be more easily applied to subsequent PRs.
| @@ -45,6 +45,10 @@ assign_issues_by: | |||
| - 'api: secretmanager' | |||
| to: | |||
| - GoogleCloudPlatform/cloud-secrets-team | |||
| - labels: | |||
| - 'api: parametermanager' | |||
There was a problem hiding this comment.
This label does not exist, they are synced to GitHub from an internal list, you need to add it internally firts and then wait for it to sync back here.
| - labels: | ||
| - 'api: parametermanager' | ||
| to: | ||
| - GoogleCloudPlatform/cloud-parameters-team |
There was a problem hiding this comment.
This group does not exist.
| @@ -30,6 +30,7 @@ appengine/flexible/ @GoogleCloudPlatform/serverless-runtimes @GoogleCloudPlatfor | |||
|
|
|||
| kms/ @GoogleCloudPlatform/dotnet-samples-reviewers | |||
| secretmanager/ @GoogleCloudPlatform/dotnet-samples-reviewers @GoogleCloudPlatform/cloud-secrets-team | |||
| secretmanager/ @GoogleCloudPlatform/dotnet-samples-reviewers @GoogleCloudPlatform/cloud-secrets-team @GoogleCloudPlatform/cloud-parameters-team | |||
There was a problem hiding this comment.
You copy pasted but didn't make all changes, this is still setting ownership for secretmanager.
This was referenced Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(parametermanager): created folder to add samples
Added a placeholder file for folder creation of parametermanager
Added cloud-parameters-team to blunderbuss.yml and CODEOWNERS