Skip to content
This repository has been archived by the owner on Feb 16, 2025. It is now read-only.

Commit

Permalink
feat: Incorporating old terraform config into new tf config (#276)
Browse files Browse the repository at this point in the history
  • Loading branch information
dinagraves authored Dec 15, 2021
1 parent 83d70a0 commit 3abc7e2
Show file tree
Hide file tree
Showing 12 changed files with 96 additions and 619 deletions.
2 changes: 1 addition & 1 deletion setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ terraform apply --auto-approve
# This allows terraform destroy to run without modifying App Engine.
# Remove this when App Engine support for terraform destroy is fixed or Firestore has a direct provisioning solution.
# https://github.com/GoogleCloudPlatform/emblem/issues/217
terraform state rm google_app_engine_application.stage_app || true
terraform state rm module.application.google_app_engine_application.main || true


## Prod Project ##
Expand Down
6 changes: 6 additions & 0 deletions terraform/app/application/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,9 @@ resource "google_storage_bucket" "sessions" {
project = data.google_project.main.project_id
provider = google
}

resource "google_storage_bucket_iam_member" "sessions-iam" {
bucket = google_storage_bucket.sessions.name
role = "roles/storage.objectAdmin"
member = "serviceAccount:${google_service_account.cloud_run_manager.email}"
}
4 changes: 4 additions & 0 deletions terraform/app/application/output.tf
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
output "project_number" {
value = data.google_project.main.number
}

output "cloud_run_manager" {
value = google_service_account.cloud_run_manager.email
}
26 changes: 26 additions & 0 deletions terraform/app/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -96,3 +96,29 @@ resource "google_pubsub_topic" "canary" {
project = data.google_project.ops.project_id
provider = google
}

##
# Secret Manager IAM Resources
##

resource "google_secret_manager_secret_iam_member" "secret_access_iam_client_id" {
project = data.google_project.ops.project_id
secret_id = data.terraform_remote_state.ops.outputs.secret_ids.client_id
role = "roles/secretmanager.secretAccessor"
member = "serviceAccount:${module.application.cloud_run_manager}"
depends_on = [
# Ensure environment setup, specifically Cloud Run Manager service account.
module.application
]
}

resource "google_secret_manager_secret_iam_member" "secret_access_iam_client_secret" {
project = data.google_project.ops.project_id
secret_id = data.terraform_remote_state.ops.outputs.secret_ids.client_secret
role = "roles/secretmanager.secretAccessor"
member = "serviceAccount:${module.application.cloud_run_manager}"
depends_on = [
# Ensure environment setup, specifically Cloud Run Manager service account.
module.application
]
}
69 changes: 0 additions & 69 deletions terraform/cloud_build_triggers.tf

This file was deleted.

245 changes: 0 additions & 245 deletions terraform/ops.tf

This file was deleted.

Loading

0 comments on commit 3abc7e2

Please sign in to comment.