Skip to content

Commit

Permalink
Merge pull request #118 from rosmo/helm-chart-ns
Browse files Browse the repository at this point in the history
Add possibility to disable namespace creation in Helm chart
  • Loading branch information
rosmo authored Mar 18, 2024
2 parents 6dbba46 + c528022 commit dafb2ad
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 11 deletions.
8 changes: 8 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -140,3 +140,11 @@ release-image: docker-build
# Push release image
release-push: release-image
${DOCKER_BIN} push ${RELEASE_IMG}:${VERSION}

helm: helm-docs helm-lint

helm-lint:
helm lint deploy/chart

helm-docs:
helm-docs
2 changes: 1 addition & 1 deletion deploy/chart/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.0
version: 0.1.1

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
3 changes: 2 additions & 1 deletion deploy/chart/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ A Helm chart for autoneg-controller-manager.
|-----|------|---------|-------------|
| annotations | object | `{}` | |
| autoscaling | object | `{}` | Autoscaling ranges, set minReplicas and maxReplicas if required |
| createNamespace | bool | `true` | |
| gke_autoneg_controller.args[0] | string | `"--health-probe-bind-address=:8081"` | |
| gke_autoneg_controller.args[1] | string | `"--metrics-bind-address=127.0.0.1:8080"` | |
| gke_autoneg_controller.args[2] | string | `"--leader-elect"` | |
Expand Down Expand Up @@ -52,4 +53,4 @@ A Helm chart for autoneg-controller-manager.
| strategy.type | string | `"RollingUpdate"` | |

----------------------------------------------
Autogenerated from chart metadata using [helm-docs v1.12.0](https://github.com/norwoodj/helm-docs/releases/v1.12.0)
Autogenerated from chart metadata using [helm-docs v1.13.1](https://github.com/norwoodj/helm-docs/releases/v1.13.1)
2 changes: 2 additions & 0 deletions deploy/chart/templates/namespace.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{ if eq .Values.createNamespace true }}
---
apiVersion: v1
kind: Namespace
Expand All @@ -9,3 +10,4 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end }}
name: {{ include "autoneg.namespace" . | quote }}
{{ end }}
21 changes: 12 additions & 9 deletions deploy/chart/values.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
---
name: &name autoneg-controller-manager

annotations: {}
createNamespace: true

annotations:
{}
# annontated: true

labels:
Expand Down Expand Up @@ -44,21 +47,21 @@ kube_rbac_proxy:
allowPrivilegeEscalation: false
privileged: false
args:
- --secure-listen-address=0.0.0.0:8443
- --upstream=http://127.0.0.1:8080/
- --logtostderr=true
- --v=10
- --secure-listen-address=0.0.0.0:8443
- --upstream=http://127.0.0.1:8080/
- --logtostderr=true
- --v=10
port: 8443

gke_autoneg_controller:
name: manager
image: ghcr.io/googlecloudplatform/gke-autoneg-controller/gke-autoneg-controller:latest
command:
- /manager
- /manager
args:
- --health-probe-bind-address=:8081
- --metrics-bind-address=127.0.0.1:8080
- --leader-elect
- --health-probe-bind-address=:8081
- --metrics-bind-address=127.0.0.1:8080
- --leader-elect
securityContext:
allowPrivilegeEscalation: false
privileged: false
Expand Down

0 comments on commit dafb2ad

Please sign in to comment.