Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parametermanager): Added global and regional samples for parameter manager #10028

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

vatsal-vora-crestdata
Copy link

@vatsal-vora-crestdata vatsal-vora-crestdata commented Feb 21, 2025

Description

Created samples for Global and Regional Parameter Manager API

Samples (Global, Regional)
quickstart
parameter-structured-data
parameter-unstructured-data
add-parameter-version (structured, unstructured)
create-parameter-secret-reference
list-all-parameters
view-parameter-details
delete-parameter
list-all-parameters-versions
view-parameter-version-details
render-secret-parameter-version
disable-parameters-version
enable-disabled-parameters-version
delete-parameter-version

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones) - This requires Parameter manager API to be enabled
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones) - This requires GOOGLE_CLOUD_PROJECT and GOOGLE_CLOUD_PROJECT_LOCATION to be set.
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 21, 2025
Copy link

snippet-bot bot commented Feb 21, 2025

Here is the summary of changes.

You are about to add 30 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@vatsal-vora-crestdata
Copy link
Author

@gptSanyam Can you provide valid product team for the parameter manager for adding in CODEOWNERS and Blunderbuss issue/PR auto-assigner

@vatsal-vora-crestdata vatsal-vora-crestdata marked this pull request as draft February 25, 2025 09:31
@vatsal-vora-crestdata vatsal-vora-crestdata marked this pull request as ready for review February 27, 2025 08:40
@vatsal-vora-crestdata vatsal-vora-crestdata changed the base branch from main to fix-issue-8966 February 27, 2025 09:06
@vatsal-vora-crestdata vatsal-vora-crestdata changed the base branch from fix-issue-8966 to main February 27, 2025 09:06
@gptSanyam gptSanyam added the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 28, 2025
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Feb 28, 2025
@enocom enocom removed the request for review from a team February 28, 2025 16:17
@telpirion telpirion added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2025
@gptSanyam gptSanyam added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 4, 2025
@gptSanyam gptSanyam added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2025
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 4, 2025
@gptSanyam gptSanyam added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 5, 2025
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants