Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigquery): add helper classes for cloud-client testing (1/3) #10034
feat(bigquery): add helper classes for cloud-client testing (1/3) #10034
Changes from 2 commits
843635d
08ee8de
398b45c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: insert region tags. Make sure that you use the same region tags as used in the same sample (create dataset) in other languages. It looks like Go uses
bigquery_create_dataset
.See https://googlecloudplatform.github.io/samples-style-guide/#region-tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now, those samples (with region tags) are in a different repo, but I need the classes to test the samples in the list. I'm planning to migrate the region tags and use the samples in this PR and repo once the PRs 10034, 10035 and 10036 are merged as that migration is not part of the current scope.
Is this a good way to go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, that makes sense. I assume that there is a work item or bug that tracks adding region tags to these files?