feat(bigquery): add dataset samples to cloud-client (2/3) #10035
Conversation
product-auto-label
bot
added
api: bigquery
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @alarconesparza, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds new samples to the Google Cloud BigQuery Cloud Client library. Specifically, it includes samples for viewing, granting, and revoking dataset access policies. The changes include a new pom.xml file for managing dependencies, as well as three new Java files (GetDatasetAccessPolicy.java, GrantAccessToDataset.java, and RevokeDatasetAccess.java) containing the sample code. Additionally, integration tests are added for each of these samples to ensure they function correctly.
Highlights
- New Samples: Adds samples for viewing, granting, and revoking dataset access policies in BigQuery.
- Dependency Management: Introduces a
pom.xmlfile to manage dependencies for the new samples. - Integration Tests: Includes integration tests to verify the functionality of the added samples.
Changelog
Click here to see the changelog
- bigquery/cloud-client/snippets/pom.xml
- Added a new
pom.xmlfile to manage dependencies for the BigQuery Cloud Client snippets. - Configured dependencies for
google-cloud-bigquery,junit, andtruth.
- Added a new
- bigquery/cloud-client/snippets/src/main/java/com/example/bigquery/GetDatasetAccessPolicy.java
- Created a new Java file
GetDatasetAccessPolicy.javato demonstrate how to view the access policy of a BigQuery dataset. - Includes code to initialize a BigQuery client, retrieve a dataset, and print its ACL details.
- Uses the
[START bigquery_view_dataset_access_policy]and[END bigquery_view_dataset_access_policy]tags to mark the sample code.
- Created a new Java file
- bigquery/cloud-client/snippets/src/main/java/com/example/bigquery/GrantAccessToDataset.java
- Created a new Java file
GrantAccessToDataset.javato demonstrate how to grant access to a BigQuery dataset. - Includes code to initialize a BigQuery client, retrieve a dataset, and add a new ACL entry to grant access to a group.
- Uses the
[START bigquery_grant_access_to_dataset]and[END bigquery_grant_access_to_dataset]tags to mark the sample code.
- Created a new Java file
- bigquery/cloud-client/snippets/src/main/java/com/example/bigquery/RevokeDatasetAccess.java
- Created a new Java file
RevokeDatasetAccess.javato demonstrate how to revoke access to a BigQuery dataset. - Includes code to initialize a BigQuery client, retrieve a dataset, and remove an ACL entry to revoke access to a group.
- Uses the
[START bigquery_revoke_dataset_access]and[END bigquery_revoke_dataset_access]tags to mark the sample code.
- Created a new Java file
- bigquery/cloud-client/snippets/src/test/java/com/example/bigquery/GetDatasetAccessPolicyIT.java
- Created a new integration test file
GetDatasetAccessPolicyIT.javafor theGetDatasetAccessPolicysample. - Includes setup and teardown methods to create and delete a dataset for testing.
- Verifies that the sample code prints the expected output containing the dataset's ACLs.
- Created a new integration test file
- bigquery/cloud-client/snippets/src/test/java/com/example/bigquery/GrantAccessToDatasetIT.java
- Created a new integration test file
GrantAccessToDatasetIT.javafor theGrantAccessToDatasetsample. - Includes setup and teardown methods to create and delete a dataset for testing.
- Verifies that the sample code successfully updates the dataset's ACLs.
- Created a new integration test file
- bigquery/cloud-client/snippets/src/test/java/com/example/bigquery/RevokeDatasetAccessIT.java
- Created a new integration test file
RevokeDatasetAccessIT.javafor theRevokeDatasetAccesssample. - Includes setup and teardown methods to create and delete a dataset, and grant access to a group, for testing.
- Verifies that the sample code successfully revokes access to the specified group.
- Created a new integration test file
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
In BigQuery's realm, where data resides,
Access control, a crucial guide.
Granting and revoking, with policies defined,
Securing datasets, for insights aligned.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request adds new samples for managing BigQuery dataset access policies. The code is generally well-structured and follows common Java conventions. However, there are a few areas that could be improved, such as the copyright year and the addition of a README.md file.
Summary of Findings
- Copyright Year: The copyright year in the license headers is set to 2025. Please confirm that this is the correct year, or update it to the current year if appropriate.
- Missing README.md: A README.md file is missing in the
bigquery/cloud-client/snippets/directory. Please add a README.md file to explain how to run the samples, what they do, and any prerequisites.
Merge Readiness
The pull request is almost ready to be merged. Before merging, please address the copyright year and add a README.md file to the bigquery/cloud-client/snippets/ directory. I am unable to approve this pull request, and recommend that others review and approve this code before merging.
| @@ -0,0 +1,70 @@ | |||
| <?xml version='1.0' encoding='UTF-8'?> | |||
| <!-- | |||
| Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
The copyright year is set to 2025. Please confirm that this is the correct year, or update it to the current year if appropriate.
| @@ -0,0 +1,66 @@ | |||
| /* | |||
| * Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
The copyright year is set to 2025. Please confirm that this is the correct year, or update it to the current year if appropriate.
| @@ -0,0 +1,71 @@ | |||
| /* | |||
| * Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
The copyright year is set to 2025. Please confirm that this is the correct year, or update it to the current year if appropriate.
| @@ -0,0 +1,76 @@ | |||
| /* | |||
| * Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
The copyright year is set to 2025. Please confirm that this is the correct year, or update it to the current year if appropriate.
| @@ -0,0 +1,82 @@ | |||
| /* | |||
| * Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
The copyright year is set to 2025. Please confirm that this is the correct year, or update it to the current year if appropriate.
| @@ -0,0 +1,87 @@ | |||
| /* | |||
| * Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
The copyright year is set to 2025. Please confirm that this is the correct year, or update it to the current year if appropriate.
| @@ -0,0 +1,89 @@ | |||
| /* | |||
| * Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
The copyright year is set to 2025. Please confirm that this is the correct year, or update it to the current year if appropriate.
alarconesparza
changed the title
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Description
Part of internal b/394478489
Second part of bigquery cloud-client (2/3).
(#10034, #10035, #10036)
This part adds samples 1, 3 and 5 from the following list:
Samples
Some of the samples are part of java-bigquery/.../bigquery repo, but are deprecated or the content does not match the docs.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only