Skip to content

fix(deps): update dependency com.microsoft.sqlserver:mssql-jdbc to v12.6.5.jre11 [security] #10201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(deps): update dependency com.microsoft.sqlserver:mssql-jdbc to v12.6.5.jre11 [security] #10201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloud-sql/sqlserver/client-side-encryption/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
<dependency>
<groupId>com.microsoft.sqlserver</groupId>
<artifactId>mssql-jdbc</artifactId>
<version>12.6.0.jre11</version>
<version>12.6.5.jre11</version>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While this version update is correct and necessary, I've noticed that the mssql-jdbc dependency version is hardcoded here and also in cloud-sql/sqlserver/servlet/pom.xml. To improve maintainability and prevent version drift between modules in the future, I recommend centralizing the version management.

A common practice in Maven is to define a property for the version in a parent pom.xml and reference it in child modules.

For example, in a parent pom.xml:

<properties>
  <mssql-jdbc.version>12.6.5.jre11</mssql-jdbc.version>
</properties>

Then, in this pom.xml and other modules:

<dependency>
  <groupId>com.microsoft.sqlserver</groupId>
  <artifactId>mssql-jdbc</artifactId>
  <version>${mssql-jdbc.version}</version>
</dependency>

This is likely out of scope for this automated PR, but it's a good practice to consider for easier future maintenance.

</dependency>
<dependency>
<groupId>com.google.crypto.tink</groupId>
Expand Down
2 changes: 1 addition & 1 deletion cloud-sql/sqlserver/servlet/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
<dependency>
<groupId>com.microsoft.sqlserver</groupId>
<artifactId>mssql-jdbc</artifactId>
<version>12.6.0.jre11</version>
<version>12.6.5.jre11</version>
</dependency>
<dependency>
<groupId>com.google.cloud.sql</groupId>
Expand Down