fix(tpu): improving tpu tests

[TetyanaYahodska]

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed Sample Format Guide
• pom.xml parent set to latest shared-configuration
• Appropriate changes to README are included in PR
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• Tests pass: mvn clean verify required
• Lint passes: mvn -P lint checkstyle:check required
• Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[minherz]

good work. thank you for finding the solution.
a few minor refactoring comments. plus a question regarding discrepancy of different runners used for different test classes

[minherz]

please add assert to verify that the return value is one that is expected to be returned by createNodeAsync() call or whatever the code sample method returns.

[TetyanaYahodska]

Since we are mocking TpuClient, we can expect that the method has been called but no resources have been created, so the return value of CreateTpuVm.createTpuVm() will be null. Based on this example

java-docs-samples/managedkafka/examples/src/test/java/examples/TopicsTest.java

Line 64 in f89f6fa

Mockito.mockStatic(ManagedKafkaClient.class)) {

we can check that a String is printed when the method is running. Should I add a print String to verify this? If we want to do E-2-E testing, we can move on to creating a real TpuClient and real resources.

[minherz]

No need to print. To your argument, since you control the return value you can ensure that the client library returns whatever you like. It is exactly the same as with e2e testing when you expect the valid not null response and you validate vs that response.
Note that not all code samples return the object they get from calling a client library method "as is". Some return only a field and others do a sequence of calls.

[minherz]

please add assert to verify that the return value is one that is expected to be returned by createQueuedResourceAsync() call or whatever the code sample method returns.

[TetyanaYahodska]

Since we are mocking TpuClient, we can expect that the method has been called but no resources have been created, so the return value of CreateQueuedResourceWithNetwork.createQueuedResourceWithNetwork() will be null. Based on this example

java-docs-samples/managedkafka/examples/src/test/java/examples/TopicsTest.java

Line 64 in f89f6fa

Mockito.mockStatic(ManagedKafkaClient.class)) {

we can check that a String is printed when the method is running. SShould I add a print String to verify this? If we want to do E-2-E testing, we can move on to creating a real TpuClient and real resources.

[minherz]

See my response in another comment thread

[minherz]

please add assert to verify that the return value is one that is expected to be returned by getQueuedResource() call or whatever the code sample method returns.

[TetyanaYahodska]

Since we are mocking TpuClient, we can expect that the method has been called but no resources have been created before, so the return value of GetQueuedResource.getQueuedResource() will be null. Based on this example

java-docs-samples/managedkafka/examples/src/test/java/examples/TopicsTest.java

Line 64 in f89f6fa

Mockito.mockStatic(ManagedKafkaClient.class)) {

we can check that a String is printed when the method is running. Should I add a print like this to verify this? If we want to do E-2-E testing, we can move on to creating a real TpuClient and real resources.

[minherz]

See my response in another comment thread

[minherz]

please add assert to verify that the return value is one that is expected to be returned by getNode() call or whatever the code sample method returns.

[TetyanaYahodska]

Since we are mocking TpuClient, we can expect that the method has been called but no resources have been created before, so the return value of GetTpuVm.getTpuVm() will be null. Based on this example

java-docs-samples/managedkafka/examples/src/test/java/examples/TopicsTest.java

Line 64 in f89f6fa

Mockito.mockStatic(ManagedKafkaClient.class)) {

we can check that a String is printed when the method is running. Should I add a print String to verify this? If we want to do E-2-E testing, we can move on to creating a real TpuClient and real resources.

[minherz]

See my response in another comment thread