Skip to content

Commit

Permalink
chore: use the right client api
Browse files Browse the repository at this point in the history
  • Loading branch information
yuwenma committed Oct 30, 2024
1 parent 3d88494 commit d1de7af
Show file tree
Hide file tree
Showing 14 changed files with 3 additions and 1,470 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ ensure:

# Should run all needed commands before any PR is sent out.
.PHONY: ready-pr
ready-pr: lint manifests resource-docs generate-go-client ensure
ready-pr: lint manifests resource-docs ensure

# Upgrades dcl dependencies
.PHONY: upgrade-dcl
Expand Down
3 changes: 1 addition & 2 deletions docs/archive/README.UpdatingTerraformProvider.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ We are actively evaluating the optimal long-term strategy for managing Terraform
2. Run `git subtree pull --prefix third_party/github.com/hashicorp/terraform-provider-google-beta https://github.com/hashicorp/terraform-provider-google-beta.git v5.X.Y --squash` from the repo’s root. This will update the provider code to the specified version.
3. Git may prompt you on merge CONFLICT, carefully review and resolve the CONFLICT to complete the git merge.
4. Run `make vet` to check if the updated code compiles.
5. Run `make generate manifests resource-docs generate-go-client` to update all
5. Run `make generate manifests resource-docs` to update all
the generated files.
6. Run `python3
scripts/generate-field-diffs-tf-upgrade/generate_field_changes.py` to
Expand Down Expand Up @@ -51,7 +51,6 @@ We are actively evaluating the optimal long-term strategy for managing Terraform
IAM support and it can’t be added, make a tracking GitHub issue and
block it temporarily in the [service mapping test code](config/tests/servicemapping/servicemapping_test.go).
1. If any new directive fields are added, you might run into issues with
ResourceSkeleton’s `TestNewFromAsset` and `TestNewFromURI` tests. Any
lingering fields in the expected vs. actual resource skeleton will
indicate which fields are suspect. If it makes sense for the field to
become a directive, add it to the resource’s corresponding
Expand Down
240 changes: 0 additions & 240 deletions scripts/generate-go-crd-clients/client_test.go

This file was deleted.

38 changes: 0 additions & 38 deletions scripts/generate-go-crd-clients/doc.go.tmpl

This file was deleted.

Loading

0 comments on commit d1de7af

Please sign in to comment.