Skip to content

direct: Implement NetworkSecurityBackendAuthenticationConfig controller - #11901

Merged
acpana merged 1 commit into
GoogleCloudPlatform:masterfrom
ada-coder-bot:issue-11894-1784878564
Jul 27, 2026
Merged

direct: Implement NetworkSecurityBackendAuthenticationConfig controller#11901
acpana merged 1 commit into
GoogleCloudPlatform:masterfrom
ada-coder-bot:issue-11894-1784878564

Conversation

@ada-coder-bot

Copy link
Copy Markdown
Collaborator

This PR implements the direct controller, E2E fixtures, and fuzzer for the NetworkSecurityBackendAuthenticationConfig resource.

Summary of Changes:

  • Direct Controller: Added the adapter reconciliation logic (Find, Create, Update, Delete, Export) under pkg/controller/direct/networksecurity/.
  • Fuzzer: Implemented and registered a KRM fuzzer under pkg/controller/direct/networksecurity/ to test and validate Spec & Status roundtripping.
  • Mock Service Extension: Implemented the mock GCP endpoints for BackendAuthenticationConfig inside mockgcp/mocknetworksecurity/.
  • Testing & Scaffolding: Added -minimal and -maximal E2E fixtures and recorded golden HTTP and Kubernetes object status outputs.
  • Harness Whitelisting: Added the resource kind to the mock GCP whitelisting logic in config/tests/samples/create/harness.go.

This PR was generated by the overseer,overseer,greenfield,step/controller agent (powered by the gemini-3.5-flash model).

Fixes #11894

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@ada-coder-bot
ada-coder-bot force-pushed the issue-11894-1784878564 branch from 8de5177 to 362b8c5 Compare July 24, 2026 09:09
@ada-coder-bot

Copy link
Copy Markdown
Collaborator Author

Investigating validate-generated-files failure

Run: 30078072196
Name: validate-generated-files
Cause: Code Error
Details: The validation check detected that pkg/controller/resourceconfig/static_config.go was out-of-date because NetworkSecurityBackendAuthenticationConfig was not sorted in correct alphabetical order (it should come after NetworkSecurityAuthzPolicy alphabetically).
Action Taken: Ran python3 dev/tasks/generate_static_config.py to regenerate the static config with correct alphabetical ordering.

Investigating unit-tests failure

Run: 30078072196
Name: unit-tests
Cause: Test Failure
Details: The API check test TestCRDFieldPresenceInTestsForAlpha failed because the recently introduced -maximal and -minimal tests for NetworkSecurityBackendAuthenticationConfig provide coverage for .spec.description, .spec.labels, .spec.location, .spec.projectRef, and .spec.wellKnownRoots fields, meaning they are no longer missing and their corresponding entries in the exceptions list tests/apichecks/testdata/exceptions/alpha-missingfields.txt had become out-of-date.
Action Taken: Regenerated the alpha exceptions list with WRITE_GOLDEN_OUTPUT=1 go test ./tests/apichecks/... -run TestCRDFieldPresenceInTestsForAlpha to match the newly added test coverage.

Investigating presubmit-gatekeeper failure

Run: 30078072196
Name: presubmit-gatekeeper
Cause: Infrastructure
Details: This gating check failed downstream of the failures in validate-generated-files and unit-tests.
Action Taken: None (it will pass automatically when the other checks are resolved).

All fixes have been committed and force-pushed to the remote branch to trigger a clean run of the CI pipeline.

(This report was generated by overseer)

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started investigating CI check failures for this pull request.

@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@ada-coder-bot
ada-coder-bot force-pushed the issue-11894-1784878564 branch from 362b8c5 to 6e8dcc7 Compare July 24, 2026 23:43
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

Implement direct controller, E2E fixtures, and fuzzer for
NetworkSecurityBackendAuthenticationConfig. This adds full reconciliation,
testing support against mockgcp, and a fuzzer for the resource.

Fix: 11894
@ada-coder-bot
ada-coder-bot force-pushed the issue-11894-1784878564 branch from 6e8dcc7 to 3e76458 Compare July 25, 2026 01:35
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

1 similar comment
@argus-watcher-bot

Copy link
Copy Markdown
Collaborator

🤖 AI Factory started resolving merge conflicts / rebasing this pull request in a sandbox.

@acpana
acpana added this pull request to the merge queue Jul 27, 2026
@google-oss-prow google-oss-prow Bot added the lgtm label Jul 27, 2026
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acpana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Merged via the queue into GoogleCloudPlatform:master with commit b135475 Jul 27, 2026
203 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved greenfield Indicates implementation of a new resource (vs migration) lgtm overseer step/controller

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Greenfield: Implement direct controller, E2E fixtures, and fuzzer for NetworkSecurityBackendAuthenticationConfig

3 participants