Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: listing direct ctrl #2993

Merged
merged 7 commits into from
Nov 26, 2024
Merged

feat: listing direct ctrl #2993

merged 7 commits into from
Nov 26, 2024

Conversation

acpana
Copy link
Collaborator

@acpana acpana commented Oct 23, 2024 •
edited
Loading

Parking some of my work for the BigQueryAnalyticsHubListing resource.

Coming as separate PRs

  • full test suite
  • fuzz test

@acpana acpana force-pushed the acpana/listing-ctrl branch from f8b6d74 to 96a6d87 Compare October 23, 2024 21:43
@acpana acpana added this to the 1.125 milestone Oct 31, 2024
@acpana acpana force-pushed the acpana/listing-ctrl branch 3 times, most recently from cab9a85 to ddb7f4a Compare November 16, 2024 00:33
@acpana acpana marked this pull request as ready for review November 16, 2024 04:32
yuwenma
yuwenma reviewed Nov 16, 2024
View reviewed changes
apis/bigqueryanalyticshub/v1alpha1/listing_types.go Outdated Show resolved Hide resolved
apis/refs/v1beta1/bigqueryref.go Outdated Show resolved Hide resolved
pkg/controller/direct/bigqueryanalyticshub/listing_controller.go Outdated Show resolved Hide resolved
pkg/controller/direct/bigqueryanalyticshub/listing_controller.go
return mapCtx.Err()
}

updateMask := &fieldmaskpb.FieldMask{}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest using comment.CompareProtoMessage

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I follow up here?

pkg/controller/direct/bigqueryanalyticshub/listing_controller.go Outdated Show resolved Hide resolved
@acpana acpana force-pushed the acpana/listing-ctrl branch 3 times, most recently from 0d79492 to 23d0bda Compare November 19, 2024 23:54
@acpana acpana requested a review from yuwenma November 20, 2024 00:06
yuwenma
yuwenma reviewed Nov 20, 2024
View reviewed changes
apis/bigqueryanalyticshub/v1alpha1/listing_reference.go Outdated Show resolved Hide resolved
apis/refs/v1beta1/bigqueryref.go
return fmt.Sprintf("projects/%s/datasets/%s/tables/%s", d.projectID, d.datasetID, d.tableID)
}

func ResolveDatasetForObject(ctx context.Context, reader client.Reader, obj *unstructured.Unstructured) (*BigQueryDataset, error) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing this to implement the ExternalNormalizer interface

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I can get rid of this just yet. If I start importing the DatasetRef from apis/bigquery we create an import cycle here. I added a TODO to remove these code blocks once we have a BigQueryTableRef

apis/refs/v1beta1/dataexchangeref.go Outdated Show resolved Hide resolved
pkg/controller/direct/bigqueryanalyticshub/listing_controller.go Outdated Show resolved Hide resolved
@yuwenma yuwenma modified the milestones: 1.125, 1.126 Nov 20, 2024
@acpana acpana force-pushed the acpana/listing-ctrl branch from b57d0cf to db7d3e0 Compare November 23, 2024 02:04
@acpana
tests: listing base
61f4f32 
Signed-off-by: Alex Pana <[email protected]>
@acpana
refactor:refs: rework refs
569b170 
Signed-off-by: Alex Pana <[email protected]>
@acpana acpana force-pushed the acpana/listing-ctrl branch from db7d3e0 to 115cfc8 Compare November 25, 2024 21:34
jingyih
jingyih reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/controller/direct/bigqueryanalyticshub/mapper.go Show resolved Hide resolved
@google-oss-prow google-oss-prow bot added the lgtm label Nov 25, 2024
@acpana acpana force-pushed the acpana/listing-ctrl branch from 115cfc8 to 4556cde Compare November 25, 2024 23:13
@google-oss-prow google-oss-prow bot removed the lgtm label Nov 25, 2024
@yuwenma
Copy link
Collaborator

yuwenma commented Nov 26, 2024

/approve

@yuwenma
Copy link
Collaborator

yuwenma commented Nov 26, 2024

/lgtm

@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the lgtm label Nov 26, 2024
@google-oss-prow google-oss-prow bot merged commit 28df5a4 into GoogleCloudPlatform:master Nov 26, 2024
18 checks passed
@acpana acpana mentioned this pull request Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwenma yuwenma yuwenma left review comments

@jingyih jingyih jingyih left review comments

Assignees

@yuwenma yuwenma

@jingyih jingyih

Labels
approved lgtm
Projects
None yet
Milestone
1.126
Development

Successfully merging this pull request may close these issues.
3 participants
@acpana @yuwenma @jingyih