chore: remove "generate-go-client" from presubmit check

Makefile

@@ -133,7 +133,6 @@ vet:
 .PHONY: generate
 generate:
 	# Don't run go generate on `pkg/clients/generated` in the normal development flow due to high latency.
-	# This path will be covered by `generate-go-client` target specifically.
 	go work vendor -o temp-vendor # So we can load DCL resources
 	go generate ./pkg/dcl/schema/...
 	rm -rf temp-vendor
@@ -221,11 +220,6 @@ install: manifests
 deploy-controller: docker-build docker-push
 	kustomize build config/installbundle/releases/scopes/cluster/withworkloadidentity | sed -e 's/$${PROJECT_ID?}/${PROJECT_ID}/g'| kubectl apply -f - ${CONTEXT_FLAG}
 
-# Generate CRD go clients
-.PHONY: generate-go-client
-generate-go-client:
-	./scripts/generate-go-crd-clients/generate-clients.sh
-
 # Generate google3 docs
 .PHONY: resource-docs
 resource-docs:
@@ -244,7 +238,7 @@ ensure:
 
 # Should run all needed commands before any PR is sent out.
 .PHONY: ready-pr
-ready-pr: lint manifests resource-docs generate-go-client ensure
+ready-pr: lint manifests resource-docs ensure
 
 # Upgrades dcl dependencies
 .PHONY: upgrade-dcl

docs/archive/README.UpdatingTerraformProvider.md

@@ -14,7 +14,7 @@ We are actively evaluating the optimal long-term strategy for managing Terraform
 2.  Run `git subtree pull --prefix third_party/github.com/hashicorp/terraform-provider-google-beta https://github.com/hashicorp/terraform-provider-google-beta.git v5.X.Y --squash` from the repo’s root. This will update the provider code to the specified version.
 3.  Git may prompt you on merge CONFLICT, carefully review and resolve the CONFLICT to complete the git merge.
 4.  Run `make vet` to check if the updated code compiles. 
-5.  Run `make generate manifests resource-docs generate-go-client` to update all
+5.  Run `make generate manifests resource-docs` to update all
     the generated files.
 6.  Run `python3
     scripts/generate-field-diffs-tf-upgrade/generate_field_changes.py` to
@@ -51,7 +51,6 @@ We are actively evaluating the optimal long-term strategy for managing Terraform
         IAM support and it can’t be added, make a tracking GitHub issue and
         block it temporarily in the [service mapping test code](config/tests/servicemapping/servicemapping_test.go).
     1.  If any new directive fields are added, you might run into issues with
-        ResourceSkeleton’s `TestNewFromAsset` and `TestNewFromURI` tests. Any
         lingering fields in the expected vs. actual resource skeleton will
         indicate which fields are suspect. If it makes sense for the field to
         become a directive, add it to the resource’s corresponding

pkg/apis/iam/v1beta1/krm_types.go

@@ -16,12 +16,6 @@ package v1beta1
 
 import "k8s.io/apimachinery/pkg/runtime/schema"
 
-// *** PLEASE READ THE FOLLOWING COMMENT BEFORE MAKING CHANGES ***
-// This ResourceReference definition is duplicated in the scripts/generate-go-crd-clients/k8s/ directory.
-// If you're making modifications to this definition, please make sure to modify
-// the corresponding struct in `types.go` (IAMResourceRef), so the generated
-// go-clients have an accurate representation of this struct.
-// ResourceReference defines a relationship to another resource
 type ResourceReference struct {
 	Kind       string `json:"kind"`
 	Namespace  string `json:"namespace,omitempty"`

pkg/apis/k8s/v1alpha1/condition_types.go

@@ -14,12 +14,6 @@
 
 package v1alpha1
 
-// *** DISCLAIMER ***
-// This file is duplicated in the scripts/generate-go-crd-clients/k8s/ directory.
-// If you're making modifications to this file, please make sure to modify the
-// corresponding file (`types.go`) so the generated go-clients have an accurate
-// representation of this package.
-
 import (
 	v1 "k8s.io/api/core/v1"
 )

pkg/util/repo/paths.go

@@ -84,10 +84,6 @@ func GetG3ResourceListsGeneratedPath() string {
 	return filepath.Join(GetRootOrLogFatal(), "scripts", "generate-google3-docs", "resource-lists", "generated")
 }
 
-func GetClientGenerationPath() string {
-	return filepath.Join(GetRootOrLogFatal(), "scripts", "generate-go-crd-clients")
-}
-
 func GetTypesGeneratedApisPath() string {
 	return filepath.Join(GetRootOrLogFatal(), "pkg", "clients", "generated", "apis")
 }
@@ -96,10 +92,6 @@ func GetBasicIntegrationTestDataPath() string {
 	return filepath.Join(GetRootOrLogFatal(), "pkg", "test", "resourcefixture", "testdata", "basic")
 }
 
-func GetTypesTemplatePath() string {
-	return filepath.Join(GetRootOrLogFatal(), "scripts", "generate-go-crd-clients")
-}
-
 func GetAutoGeneratedServiceMappingsPathOrLogFatal() string {
 	return filepath.Join(GetRootOrLogFatal(), "scripts", "resource-autogen", "generated", "servicemappings")
 }