Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.125.0-rc.1 #3116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Release 1.125.0-rc.1 #3116

wants to merge 1 commit into from

Conversation

yuwenma
Copy link
Collaborator

@yuwenma yuwenma commented Nov 6, 2024

No description provided.

@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from yuwenma. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yuwenma
yuwenma commented Nov 6, 2024
View reviewed changes
operator/config/gke-addon/image_configmap.yaml
cnrm.unmanageddetector: gcr.io/gke-release/cnrm/unmanageddetector:7a86865
cnrm.webhook: gcr.io/gke-release/cnrm/webhook:7a86865
prom-to-sd: gcr.io/gke-release/prometheus-to-sd:v0.11.12-gke.11
cnrm.controller: gcr.io/gke-release/cnrm/controller:1.125.0-rc.1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinsb does this look right to you?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. This is where we will eventually promote the image to, I believe!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see - you mean that most of the images are missing ... something has gone wrong. I'll try to pull and see if I can understand why!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuwenma @justinsb