feat: Generate and fixup WorkstationConfig mapping functions #3136
+811
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jasonvigil
force-pushed
the
workstationconfig-mappers
branch
from
5beb175
to
0cebff1
Compare
jasonvigil
force-pushed
the
workstationconfig-mappers
branch
6 times, most recently
from
2611cf6
to
bb003c1
Compare
jasonvigil
force-pushed
the
workstationconfig-mappers
branch
from
bb003c1
to
3f85d2c
Compare
jasonvigil
changed the title
jasonvigil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to rename some of the shared mapping functions previously (had meant to do that in #3159). So, renamed and fixed the shared mapping function names in this commit also.
Also, for now, using
_Alphato distinguish between shared mapping functions that act on the v1alpha1 API vs the "normal" shared mapping functions that act on the v1beta1 API, but they are functionally equivalent. Will delete these functions and switch over to the "normal", non-_Alpha(v1beta1) version ones upon promoting WorkstationConfig to v1beta1.