-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Skip checking for changes in reference field #3169
tests: Skip checking for changes in reference field #3169
Conversation
334b5ea
to
1297e2f
Compare
/lgtm |
// Manually add those fields to the skipped fields list. | ||
// todo: Determine if we want to have "Refs" in those field names, like "targetResourceRefs" | ||
// That would introduce breaking changes to DCL/TF resource | ||
computeFirewallPolicyRuleSkippedFields := []string{"targetResources", "targetServiceAccounts"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit, I feel like this would be a bit easier to read if the computeFirewallPolicyRuleSkippedFields
was defined right before it was used, on line 849.
1297e2f
to
55a0b73
Compare
/lgtm |
/approve Thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
55a0b73
to
4343c5c
Compare
New changes are detected. LGTM label has been removed. |
3479289
into
GoogleCloudPlatform:master
Change description
Fixes dynamic tests:
basic-computefirewallpolicyrule-egress-full-direct
basic-computefirewallpolicyrule-ingress-full-direct
Tests you have done
make ready-pr
to ensure this PR is ready for review.