Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Skip checking for changes in reference field #3169

Conversation

gemmahou
Copy link
Collaborator

@gemmahou gemmahou commented Nov 13, 2024

Change description

Fixes dynamic tests:
basic-computefirewallpolicyrule-egress-full-direct
basic-computefirewallpolicyrule-ingress-full-direct

Tests you have done

--- PASS: TestCreateNoChangeUpdateDelete (0.16s)
    --- PASS: TestCreateNoChangeUpdateDelete/compute (0.00s)
        --- PASS: TestCreateNoChangeUpdateDelete/compute/basic-computefirewallpolicyrule-egress-full-direct (303.03s)
PASS
{"severity":"info","timestamp":"2024-11-13T09:43:57.826Z","msg":"Stopping and waiting for non leader election runnables"}
{"severity":"info","timestamp":"2024-11-13T09:43:57.826Z","msg":"Stopping and waiting for leader election runnables"}
{"severity":"info","timestamp":"2024-11-13T09:43:57.826Z","msg":"Stopping and waiting for caches"}
{"severity":"info","timestamp":"2024-11-13T09:43:57.827Z","msg":"Stopping and waiting for webhooks"}
{"severity":"info","timestamp":"2024-11-13T09:43:57.827Z","logger":"controller-runtime.webhook","msg":"Shutting down webhook server with timeout of 1 minute"}
{"severity":"info","timestamp":"2024-11-13T09:43:57.827Z","msg":"Wait completed, proceeding to shutdown the manager"}
ok      github.com/GoogleCloudPlatform/k8s-config-connector/pkg/controller/dynamic      313.224s
--- PASS: TestCreateNoChangeUpdateDelete (0.16s)
    --- PASS: TestCreateNoChangeUpdateDelete/compute (0.00s)
        --- PASS: TestCreateNoChangeUpdateDelete/compute/basic-computefirewallpolicyrule-ingress-full-direct (392.79s)
PASS
{"severity":"info","timestamp":"2024-11-13T16:09:00.110Z","msg":"Stopping and waiting for non leader election runnables"}
{"severity":"info","timestamp":"2024-11-13T16:09:00.110Z","msg":"Stopping and waiting for leader election runnables"}
{"severity":"info","timestamp":"2024-11-13T16:09:00.110Z","msg":"Stopping and waiting for caches"}
{"severity":"info","timestamp":"2024-11-13T16:09:00.110Z","msg":"Stopping and waiting for webhooks"}
{"severity":"info","timestamp":"2024-11-13T16:09:00.110Z","logger":"controller-runtime.webhook","msg":"Shutting down webhook server with timeout of 1 minute"}
{"severity":"info","timestamp":"2024-11-13T16:09:00.110Z","msg":"Wait completed, proceeding to shutdown the manager"}
ok      github.com/GoogleCloudPlatform/k8s-config-connector/pkg/controller/dynamic      402.967s
  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@jasonvigil
Copy link
Collaborator

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 13, 2024
// Manually add those fields to the skipped fields list.
// todo: Determine if we want to have "Refs" in those field names, like "targetResourceRefs"
// That would introduce breaking changes to DCL/TF resource
computeFirewallPolicyRuleSkippedFields := []string{"targetResources", "targetServiceAccounts"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, I feel like this would be a bit easier to read if the computeFirewallPolicyRuleSkippedFields was defined right before it was used, on line 849.

@gemmahou gemmahou force-pushed the firewallpolicyrule-direct-test branch from 1297e2f to 55a0b73 Compare November 14, 2024 00:40
@google-oss-prow google-oss-prow bot removed the lgtm label Nov 14, 2024
@jasonvigil
Copy link
Collaborator

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 14, 2024
@yuwenma
Copy link
Collaborator

yuwenma commented Nov 14, 2024

/approve

Thanks

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemmahou gemmahou force-pushed the firewallpolicyrule-direct-test branch from 55a0b73 to 4343c5c Compare November 14, 2024 22:10
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot removed the lgtm label Nov 14, 2024
@google-oss-prow google-oss-prow bot merged commit 3479289 into GoogleCloudPlatform:master Nov 14, 2024
2 checks passed
@gemmahou gemmahou deleted the firewallpolicyrule-direct-test branch November 14, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants