tests: simple backoff on direct dynamic #3172
Conversation
| if err == nil && found { | ||
| op := directbase.NewDeleteOperation(c, u) | ||
| _, err = a.Delete(ctx, op) | ||
| if err == nil { |
There was a problem hiding this comment.
Is it possible that err != nil but the deletion is still completed? I remember some resources may return an error during creation but still create the resource.
In that case we'll get err == nil && !found, and return an error in the second iteration, right? So maybe let only do err == nil && !found check for the first iteration?
There was a problem hiding this comment.
Oh interesting I didn't know that -- I can adjust the code to function like that!
There was a problem hiding this comment.
It may not be a common case. But I think NotFound in general can be considered fine when the resource was found in the first deletion.
Signed-off-by: Alex Pana <[email protected]>
acpana
force-pushed
the
acpana/dynamic-delete-retries
branch
from
b3dc742
to
2d2a67d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maqiuyujoyce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 2656148
into
GoogleCloudPlatform:master
Going off of #3162 , let's add a simple exp backoff to the delete. The underlying 1P API calls may benefit from this. Ideally we'd get the retries for free from the testing framework but starting off here for now.