-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: release note draft #3177
base: master
Are you sure you want to change the base?
fix: release note draft #3177
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Previously we added [rate-limit control in namespace mode](https://cloud.google.com/config-connector/docs/how-to/customize-controller-manager-rate-limit). Users can configure the `NamespacedControllerReconciler` object to set the rate-limit for the reconciling requests to the kube-apiserver for their Config Connector resources. | ||
* This release adds this feature in the cluster mode in `ControllerReconciler` object. This [example](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/operator/config/samples/controller_reconciler_customization_sample.yaml) shows how to set up the configuration. | ||
* In v1.119, we added [rate-limit control in namespace mode](https://cloud.google.com/config-connector/docs/how-to/customize-controller-manager-rate-limit). Users can configure `NamespacedControllerReconciler` object (Alpha) to set the rate-limit for the reconciling requests to the kube-apiserver for their Config Connector resources. | ||
* In this release, we add this feature for cluster mode. User can configure `ControllerReconciler` object (Alpha) to set the rate-limit for all their cnrm manager controllers in the cluster. This [example](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/operator/config/samples/controller_reconciler_customization_sample.yaml) shows how to set up the configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configure the ControllerReconciler
|
||
We migrated the following resources from the Terraform-based or DCL-based controller to the new Direct Controller to enhance the reliability and performance. The resource CRD is unchanged. | ||
|
||
* `SQLInstance` | ||
* [`SQLInstance`](https://github.com/GoogleCloudPlatform/k8s-config-connector/tree/master/pkg/test/resourcefixture/testdata/basic/sql/v1beta1/sqlinstance) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonvigil check my recollection. We have added support for running SQLInstance via Direct Controller but not actually migrated to it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair. Maybe the wording should say we "added support" for the direct controller, instead of "migrated"
Change description
Fixes #
Tests you have done
make ready-pr
to ensure this PR is ready for review.