apis: ApigeeEnvgroupAttachment #3605
Conversation
| } | ||
|
|
||
| // ApigeeEnvgroupAttachmentStatus defines the observed state of ApigeeEnvgroupAttachment | ||
| type ApigeeEnvgroupAttachmentStatus struct { |
There was a problem hiding this comment.
There should be an observedState.createdAt field?
There was a problem hiding this comment.
Let's add this in once we have the direct controller!
There was a problem hiding this comment.
Curious why would we wait to add this field? The API is already not compatible with the legacy DCL controller.
acpana
force-pushed
the
acpana/aega-types
branch
2 times, most recently
from
046c738 to
c51d2b3
Compare
acpana
force-pushed
the
acpana/aega-types
branch
from
c51d2b3 to
be0b17a
Compare
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
acpana
force-pushed
the
acpana/aega-types
branch
from
19b311c to
f28af05
Compare
| return "", fmt.Errorf("reading referenced %s %s: %w", EnvironmentGVK, key, err) | ||
| } | ||
| // Get external from status.externalRef. This is the most trustworthy place. | ||
| actualExternalRef, found, err := unstructured.NestedString(u.Object, "status", "externalRef") |
There was a problem hiding this comment.
Just realized this will not work actually, there is no status.externalRef field in the existing ApigeeEnvironment type. I created a PR to define types/refs for ApigeeEnvironment (and ApigeeOrganization), you will need to rebase to use updated code.
There was a problem hiding this comment.
Yup that's why I have my TODO lower. There's been chatter about how to fix this in a separate PR (for a different resource). I don't think we should block on this for now. TL;DR - for TF or DCL resources this field will not be populated. But I think we have a path forward.
Can we close on this PR so I can focus on the TODO (and the remaining work items) ?
There was a problem hiding this comment.
/approve
/assign @jasonvigil
Defer to Jason for the final vote.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
google-oss-prow
bot
merged commit 94663d7
into
GoogleCloudPlatform:master
Adds direct style APIs for the
ApigeeEnvgroupAttachment. This is an alpha resource, still running over the TF controller.Next PR:
change envgroup and environment fields to references![ did it in this PR ]